Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1588 frontend ribbon app titles branding #2192

Closed
wants to merge 7 commits into from

Conversation

adele-usdr
Copy link
Contributor

Ticket #1588

Description

Update nav bar style and tool name, along with Login screen

Screenshots / Demo Video

Screenshot 2023-11-07 at 5 35 07 PM

Testing

Tested with and without the profile feature flag on in deploy-config.js
Tested Login screen by logging out and confirming tool name change

Automated and Unit Tests

  • Added Unit tests

Manual tests for Reviewer

  • [x ] Added steps to test feature/functionality manually

Checklist

  • [x ] Provided ticket and description
  • [x ] Provided screenshots/demo
  • [x ] Provided testing information
  • Provided adequate test coverage for all new code
  • [ x] Added PR reviewers

Copy link

codeclimate bot commented Nov 8, 2023

Code Climate has analyzed commit ce52679 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.9% (0.0% change).

View more on Code Climate.

@adele-usdr
Copy link
Contributor Author

I'd like extra eyes on how I used conditional properties here and v-if/else. Not sure if that's all the right style.

@adele-usdr
Copy link
Contributor Author

ah forgot to but the login branding behind the feature flat

@adele-usdr adele-usdr closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant