Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1588 frontend ribbon app titles branding #2193

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

adele-usdr
Copy link
Contributor

Ticket #1588

Description

Nav bar and Login branding updates

Screenshots / Demo Video

Screenshot 2023-11-07 at 5 35 23 PM Screenshot 2023-11-07 at 5 35 07 PM Screenshot 2023-11-07 at 6 01 05 PM

Testing

Tested Nav bar and Login screen changes with and without the profile flag on in deploy-config.js

Automated and Unit Tests

  • Added Unit tests

Manual tests for Reviewer

  • [ x] Added steps to test feature/functionality manually

Checklist

  • [x ] Provided ticket and description
  • [ x] Provided screenshots/demo
  • [ x] Provided testing information
  • Provided adequate test coverage for all new code
  • [x ] Added PR reviewers

Copy link

codeclimate bot commented Nov 8, 2023

Code Climate has analyzed commit f20959b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@as1729 as1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@as1729 as1729 enabled auto-merge (squash) November 8, 2023 17:04
@as1729 as1729 merged commit 0bc1172 into _staging Nov 8, 2023
5 checks passed
@as1729 as1729 deleted the 1588-frontend-ribbon-app-titles-branding branch November 8, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants