Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add migration for cascading delete on users -> saved searches #2202 #2207

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

dysmento
Copy link
Contributor

@dysmento dysmento commented Nov 10, 2023

Ticket #2202

Description

Adds the necessary migration to update the foreign key constraint on grants_saved_searches.created_by

This will allow deleting of users with saved searches.

I use four transactions within the migration for each of the four steps described in the ticket.

@dysmento dysmento self-assigned this Nov 10, 2023
@dysmento dysmento linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Contributor

@as1729 as1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@as1729 as1729 enabled auto-merge (squash) November 13, 2023 13:30
Copy link

codeclimate bot commented Nov 13, 2023

Code Climate has analyzed commit a78aa6a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.9%.

View more on Code Climate.

@as1729 as1729 merged commit ddcf2d5 into _staging Nov 13, 2023
4 checks passed
@as1729 as1729 deleted the zt/2202-add-cascading-delete-for-saved-searches branch November 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

partner can't delete users
2 participants