Fix: Frontend enhancements - style, typography, app name updates (#1928) #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
saboteurina
force-pushed
the
1928-grant-finder-frontend-enhancements
branch
from
4767338 to
3c1d33b
Compare
saboteurina
changed the title
Looks good! Does this the text need more space here in the Grant Details UI?
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
@adele-usdr yes - good catch! redid some of my grant details updates in the latest push: |
|
Code Climate has analyzed commit 4a0e63b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 57.1% (0.0% change). View more on Code Climate. |
denhsieh
pushed a commit
that referenced
this pull request
Dec 3, 2023
…) (#2249) * WIP updates to typography and button styles * final updates to typography, buttons, colors, login screen, styling.md doc * updating styles after pulling in latest versions with the new terminology * updating homepage unit test based on the updates * updating cypress test to reflect app name change * adding back the admin delete changes with the terminology change * minor cleanup items * minor updates on grant details styling * fix: remove unintended yarn.lock changes --------- Co-authored-by: adele-usdr <[email protected]>
TylerHendrickson
added
documentation
TylerHendrickson
added a commit
that referenced
this pull request
Dec 8, 2023
* chore(deps): bump @aws-sdk/s3-request-presigner from 3.458.0 to 3.462.0 (#2286) Bumps [@aws-sdk/s3-request-presigner](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/s3-request-presigner) from 3.458.0 to 3.462.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/s3-request-presigner/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.462.0/packages/s3-request-presigner) --- updated-dependencies: - dependency-name: "@aws-sdk/s3-request-presigner" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @aws-sdk/client-sqs from 3.458.0 to 3.462.0 (#2287) Bumps [@aws-sdk/client-sqs](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-sqs) from 3.458.0 to 3.462.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sqs/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.462.0/clients/client-sqs) --- updated-dependencies: - dependency-name: "@aws-sdk/client-sqs" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @aws-sdk/rds-signer from 3.458.0 to 3.462.0 (#2289) Bumps [@aws-sdk/rds-signer](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/rds-signer) from 3.458.0 to 3.462.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/rds-signer/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.462.0/packages/rds-signer) --- updated-dependencies: - dependency-name: "@aws-sdk/rds-signer" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @aws-sdk/client-s3 from 3.458.0 to 3.462.0 (#2288) Bumps [@aws-sdk/client-s3](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-s3) from 3.458.0 to 3.462.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.462.0/clients/client-s3) --- updated-dependencies: - dependency-name: "@aws-sdk/client-s3" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @aws-sdk/client-ses from 3.458.0 to 3.462.0 (#2290) Bumps [@aws-sdk/client-ses](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-ses) from 3.458.0 to 3.462.0. - [Release notes](https://github.com/aws/aws-sdk-js-v3/releases) - [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ses/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.462.0/clients/client-ses) --- updated-dependencies: - dependency-name: "@aws-sdk/client-ses" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: Frontend enhancements - style, typography, app name updates (#1928) (#2249) * WIP updates to typography and button styles * final updates to typography, buttons, colors, login screen, styling.md doc * updating styles after pulling in latest versions with the new terminology * updating homepage unit test based on the updates * updating cypress test to reflect app name change * adding back the admin delete changes with the terminology change * minor cleanup items * minor updates on grant details styling * fix: remove unintended yarn.lock changes --------- Co-authored-by: adele-usdr <[email protected]> * feat: add breadcrumb back to home from my profile * feat: add breadcrumb back to home from my profile * fixed the home URL this was previously going to grants#/my-grants instead of #/grants --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rowena <[email protected]> Co-authored-by: adele-usdr <[email protected]> Co-authored-by: Tyler Hendrickson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #1928
Description
Front-end updates to Grant Finder, including:
There are no functionality updates.
Screenshots / Demo Video
See ticket #1928 for screenshots and a demo of the login screen
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist