Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2273 use stacked table layout for narrow windows #2291

Conversation

adele-usdr
Copy link
Contributor

Ticket #2273

Grants table layout should become stacked when the window is narrow

Screenshots / Demo Video

Screen.Recording.2023-11-29.at.10.29.18.AM.mov

Testing

Test on mobile and with different window sizes

Automated and Unit Tests

  • Added Unit tests

Manual tests for Reviewer

  • [x ] Added steps to test feature/functionality manually

Checklist

  • [x ] Provided ticket and description
  • [ x] Provided screenshots/demo
  • [x ] Provided testing information
  • Provided adequate test coverage for all new code
  • [x ] Added PR reviewers

@adele-usdr
Copy link
Contributor Author

This matches how grants.gov does narrow layouts

@adele-usdr adele-usdr enabled auto-merge (squash) November 30, 2023 18:24
Copy link

codeclimate bot commented Dec 5, 2023

Code Climate has analyzed commit 453ec31 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.1% (0.0% change).

View more on Code Climate.

@adele-usdr adele-usdr merged commit 0423a16 into _staging Dec 5, 2023
6 checks passed
@adele-usdr adele-usdr deleted the 2273-grants-table-layout-should-become-stacked-when-the-window-is-narrow-take2 branch December 5, 2023 16:40
@TylerHendrickson TylerHendrickson added the enhancement New feature or request label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grants table layout should become stacked when the window is narrow
3 participants