Updates to vscode workspace settings #2814
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Should this file be moved to the root directory? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| [*.{js,jsx,ts,tsx,vue,json,yaml,yml,tf,tfvars}] | ||
| indent_style = space | ||
| indent_size = 2 | ||
| end_of_line = lf | ||
|
|
||
|
There was a problem hiding this comment. My two cents: we should...
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,51 @@ | ||
| { | ||
| "folders": [ | ||
| { | ||
| "name": "✨ usdr-gost", | ||
| "path": "." | ||
| }, | ||
| { | ||
| "name": "📦 client", | ||
| "path": "packages/client" | ||
| }, | ||
| { | ||
| "name": "📦 server", | ||
| "path": "packages/server" | ||
| } | ||
| ], | ||
| "settings": { | ||
| "window.zoomLevel": 0, | ||
| "diffEditor.ignoreTrimWhitespace": false, | ||
| "editor.columnSelection": false, | ||
| "editor.find.cursorMoveOnType": true, | ||
| "javascript.format.enable": false, | ||
| "files.trimTrailingWhitespace": true, | ||
| "files.insertFinalNewline": true, | ||
| "files.eol": "\n", | ||
| "editor.detectIndentation": false, | ||
| "editor.codeActionsOnSave": { | ||
| "source.fixAll.eslint": "explicit", | ||
| "source.sortImports": "explicit", | ||
| "source.formatAll.terraform": "explicit", | ||
| }, | ||
| // We need to explicitly turn this off at the worksplace level to avoid | ||
| // competing user settings and workplace settings. We use VSCode's "codeActionsOnSave" | ||
| // to manage linting/fixing, but users can have other settings via "formatOnSave". | ||
| // If both are on, the editor can "fix" things that are immediately flagged as lint failures. | ||
| "editor.formatOnSave": false, | ||
| "[yaml]": { | ||
| "editor.defaultFormatter": "redhat.vscode-yaml", | ||
| "editor.formatOnSave": true, | ||
| }, | ||
| "[json][jsonc][jsonl]": { | ||
| "editor.defaultFormatter": "vscode.json-language-features", | ||
| "editor.formatOnSave": true, | ||
| }, | ||
| "[terraform]": { | ||
| "editor.defaultFormatter": "hashicorp.terraform", | ||
| }, | ||
| "[terraform-vars]": { | ||
| "editor.defaultFormatter": "hashicorp.terraform", | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few other extensions that might be nice to include here:
bpruitt-goddard.mermaid-markdown-syntax-highlighting(link): Mermaid is recommended in our ADR docs, and is used inADR 1, so syntax highlighting support seems useful.bierner.markdown-mermaid(link): Similar to above, being able to preview mermaid diagrams feels all but necessary to effectively create a mermaid diagram.github.vscode-github-actions(link): Super useful for editing our GitHub automations.mikestead.dotenv(link): Helpful for folks who are less familiar with editing dotenv files.