-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gost): update vitest version and add testing-library for accessible queries #3794
Conversation
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @TylerHendrickson, Action: |
981f7e4
to
d23c05a
Compare
@lsr-explore re
I've been holding off on reviewing #3635 because it's still a Draft PR – should that still be the case? And is that a prerequisite for this PR? |
c04ca43
to
887bba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsr-explore Changes look good (and thanks for the ADR write-up)!
Ticket #3756
Description
Add support for testing-library/vue to be able to use accessible queries and update vitest package version.
From Testing Library Docs on queries
Queries Accessible to Everyone Queries that reflect the experience of visual/mouse users as well as those that use assistive technology.
Note:
Opened this PR to add support for accessible queries using the embedded version of testing-library from vitest
PR #3635 - Update vitest and add support for browser tests
Screenshots / Demo Video
Testing library tests are a bit more readable and don't rely on ids
Vitest
Testing library
Added tests in HomeView.spec.js increase the test coverage for HomeView.vue
Before - HomeView coverage
After - HomeView coverage
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist