stickydisk: ensure runner perms are maintained when mounting stickydisk #4
+86
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7b5a24c in 39 seconds
More details
- Looked at
70lines of code in2files - Skipped
6files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. stickydisk.js:106
- Draft comment:
Using$(id -u)and$(id -g)in shell commands can lead to command injection vulnerabilities. Consider using Node.js methods to get user and group IDs and pass them as variables. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_RcuEzPr2SZA797qR
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| // -m0: Disable reserved blocks (all space available to non-root users) | ||
| // root_owner=$(id -u):$(id -g): Sets filesystem root directory owner to current (runner) user | ||
| // This ensures the filesystem is owned by runner user from the start | ||
| await execAsync(`sudo mkfs.ext4 -m0 -E root_owner=$(id -u):$(id -g) -Enodiscard,lazy_itable_init=1,lazy_journal_init=1 -F ${device}`); |
There was a problem hiding this comment.
Using $(id -u) and $(id -g) in shell commands can lead to command injection vulnerabilities. Consider using Node.js methods to get user and group IDs and pass them as variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Ensure runner permissions are maintained when mounting stickydisk by adjusting filesystem and mount operations in
stickydisk.js.stickydisk.js,maybeFormatBlockDevice()now usessudoforblkid,resize2fs, andmkfs.ext4to ensure root access, setting filesystem ownership to the runner user.mountStickyDisk()creates mount points withoutsudoand mounts with options to set file ownership and permissions for the runner user..github/workflows/ci.yml, adds a step to create a Bazel cache directory on non-Windows systems.This description was created by
for 7b5a24c. It will automatically update as commits are pushed.