Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme to follow setup-gradle action #147

Conversation

okuzawats
Copy link

In this PR, I update Readme to follow setup-gradle action major update.

setup-gradle action v4 has released and the arguments parameter has removed.

Instead of arguments parameter, it is recommended to run gradle task directly. So I'd like to fix the Readme.

Comment on lines +34 to +35
- name: Run dependencies
run: ./gradlew dependencies
Copy link
Member

@mateuszkwiecinski mateuszkwiecinski Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acutally this shouldn't be needed anymore 👍 I don't remember why this was needed in the first place, but it can be safely removed now since setup-gradle properly picks up all caches

@mateuszkwiecinski
Copy link
Member

mateuszkwiecinski commented Aug 8, 2024

I updated this and all other actions withing Readme in: #148, thanks for noticing and fixing the issue! 🙇

@okuzawats
Copy link
Author

thanks!

@okuzawats okuzawats deleted the setup-gradle-arguments-deprecated branch August 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants