Skip to content

Commit

Permalink
Bump actions, fix nullability, fix codestyle
Browse files Browse the repository at this point in the history
  • Loading branch information
mateuszkwiecinski committed Jan 29, 2024
1 parent 8c4e371 commit 5307eab
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 19 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

- uses: gradle/wrapper-validation-action@v1

- uses: gradle/gradle-build-action@v2
- uses: gradle/actions/setup-gradle@v3

- run: ./gradlew assemble

Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
distribution: 'temurin'
java-version: ${{ matrix.java }}

- uses: gradle/gradle-build-action@v2
- uses: gradle/actions/setup-gradle@v3
continue-on-error: true
with:
build-root-directory: sample
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
java-version: 21

- name: Assemble
uses: gradle/gradle-build-action@v2
uses: gradle/actions/setup-gradle@v3
with:
arguments: assemble -m

Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
java-version: 21

- name: Assemble
uses: gradle/gradle-build-action@v2
uses: gradle/actions/setup-gradle@v3
with:
arguments: assemble -m

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/diffuse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
key: diffuse-${{ github.event.pull_request.base.sha }}-always-cache-miss
restore-keys: diffuse-${{ github.event.pull_request.base.sha }}

- uses: gradle/gradle-build-action@v2
- uses: gradle/actions/setup-gradle@v3

- run: ./gradlew assemble -PskipJarVersion

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
distribution: 'temurin'
java-version: 21

- uses: gradle/gradle-build-action@v2
- uses: gradle/actions/setup-gradle@v3

- name: Unwrap GPG key
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
java-version: 21

- name: Build app with Gradle
uses: gradle/gradle-build-action@v2
uses: gradle/actions/setup-gradle@v3

- run: ./gradlew assemble

Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
distribution: 'temurin'
java-version: 21

- uses: gradle/gradle-build-action@v2
- uses: gradle/actions/setup-gradle@v3

- run: ./gradlew assemble -PskipJarVersion

Expand Down
2 changes: 1 addition & 1 deletion sample/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ maven-junit = "5.10.1"
maven-junit4 = "4.13.2"
maven-assertj = "3.25.2"
activity-compose = "1.8.2"
androidx-compose-compiler = "1.5.4"
androidx-compose-compiler = "1.5.8"
androidx-core = "1.12.0"
androidx-test-ext-junit = "1.1.5"
com-squareup-moshi = "1.15.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ data class Scm(val url: String)

@Serializable
data class UnknownLicenses(
val name: String,
val url: String,
val name: String?,
val url: String?,
)

@Serializable
Expand Down
4 changes: 2 additions & 2 deletions sample/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ pluginManagement {
}
gradlePluginPortal {
content {
excludeModule("io.github.usefulness", "lincensee-for-android")
excludeModule("io.github.usefulness", "licensee-for-android")
}
}
}
Expand All @@ -33,7 +33,7 @@ dependencyResolutionManagement {
google()
mavenCentral {
content {
excludeModule("io.github.usefulness", "lincensee-for-android-core")
excludeModule("io.github.usefulness", "licensee-for-android-core")
}
}
}
Expand Down
14 changes: 8 additions & 6 deletions sample/ui/src/main/kotlin/se/premex/gross/ui/OssView.kt
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ private data class ViewArtifact(
)

private data class ViewLicense(
val title: String,
val url: String,
val title: String?,
val url: String?,
)

@Composable
Expand Down Expand Up @@ -158,17 +158,19 @@ private fun LicenseSelector(dialogData: LicensesDialogData, onDismissRequest: ()
dialogData.licenses.forEach { license ->
ListItem(
headlineContent = {
Text(text = license.title)
license.title?.let { Text(text = it) }
},
leadingContent = {
Icon(
imageVector = Icons.Filled.Link,
contentDescription = null,
)
},
modifier = Modifier.clickable {
uriHandler.openUri(license.url)
},
modifier = license.url?.let { url ->
Modifier.clickable {
uriHandler.openUri(url)
}
} ?: Modifier,
)
}
}
Expand Down

0 comments on commit 5307eab

Please sign in to comment.