Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UnknownLicense's fields nullable #78

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Make UnknownLicense's fields nullable #78

merged 2 commits into from
Jan 29, 2024

Conversation

mateuszkwiecinski
Copy link
Member

@mateuszkwiecinski mateuszkwiecinski commented Jan 29, 2024

Fixes #73

Copy link

Diffuse output:

OLD: diffuse-base-file
NEW: licensee-for-android.jar

       │          compressed          │          uncompressed          
       ├──────────┬──────────┬────────┼───────────┬───────────┬────────
 JAR   │ old      │ new      │ diff   │ old       │ new       │ diff   
───────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
 class │ 67.8 KiB │ 67.9 KiB │ +153 B │   147 KiB │ 147.5 KiB │ +547 B 
 other │  1.6 KiB │  1.6 KiB │    0 B │     189 B │     189 B │    0 B 
───────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
 total │ 69.4 KiB │ 69.5 KiB │ +153 B │ 147.1 KiB │ 147.7 KiB │ +547 B 

 CLASSES │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  39 │  39 │ 0 (+0 -0) 
 methods │ 357 │ 357 │ 0 (+0 -0) 
  fields │  90 │  90 │ 0 (+0 -0)
JAR
    compressed    │   uncompressed    │                                                                                 
─────────┬────────┼──────────┬────────┤                                                                                 
 size    │ diff   │ size     │ diff   │ path                                                                            
─────────┼────────┼──────────┼────────┼─────────────────────────────────────────────────────────────────────────────────
 2.4 KiB │ +100 B │  5.9 KiB │ +344 B │ ∆ io/github/usefulness/licensee/serialization/UnknownLicenses__serializer.class 
 2.4 KiB │  +53 B │  5.3 KiB │ +203 B │ ∆ io/github/usefulness/licensee/serialization/UnknownLicenses.class             
─────────┼────────┼──────────┼────────┼─────────────────────────────────────────────────────────────────────────────────
 4.8 KiB │ +153 B │ 11.2 KiB │ +547 B │ (total)

@mateuszkwiecinski mateuszkwiecinski changed the title Make unknown Licenses nullable Make UnknownLicenses fields nullable Jan 29, 2024
@mateuszkwiecinski mateuszkwiecinski changed the title Make UnknownLicenses fields nullable Make UnknownLicenses fields nullable Jan 29, 2024
@mateuszkwiecinski mateuszkwiecinski changed the title Make UnknownLicenses fields nullable Make UnknownLicense's fields nullable Jan 29, 2024
@mateuszkwiecinski mateuszkwiecinski merged commit 8dbbb9c into master Jan 29, 2024
10 checks passed
@mateuszkwiecinski mateuszkwiecinski deleted the updates branch January 29, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception decoding artifacts.json due to null field
1 participant