Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor bluesky plugin #42

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Refactor bluesky plugin #42

merged 1 commit into from
Jun 13, 2024

Conversation

arash77
Copy link
Collaborator

@arash77 arash77 commented Jun 12, 2024 •
edited
Loading

This pull request refactors the bluesky_client module.

The changes address two areas:

  • Fixing warnings: The code has been updated to address any warnings previously encountered in the handle_url_card function.
  • Enhancing status check: The logic for checking the posted content's status has been revised. This addresses an issue where the function might incorrectly return "false" even when content is successfully posted.

wm75
wm75 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@wm75 wm75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complex stuff and I don't have a bluesky account for testing, but looks ok and I assume you know what you are doing :-)

@arash77 arash77 merged commit e874d66 into main Jun 13, 2024
1 check passed
@arash77 arash77 deleted the arash-refactor-bluesky branch June 13, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wm75 wm75 wm75 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arash77 @wm75