Updates node to 20, React to 18, FA peer dep to latest #1180
Conversation
| @@ -8,7 +8,6 @@ import 'scss/forms/input_label.scss'; | |||
|
|
|||
| const InputLabel = ({ | |||
| className, | |||
| elementType, | |||
There was a problem hiding this comment.
this prop isn't used in the component, so I just removed it
There was a problem hiding this comment.
This prop isn't being used anywhere in rails-server either so that's good
| @@ -145,7 +145,6 @@ export default class SidebarView extends Component { | |||
| const sidebarClassName = classNames( | |||
| this.props.className, | |||
| { | |||
| // eslint-disable-next-line @typescript-eslint/camelcase | |||
There was a problem hiding this comment.
updating TS lint made this obsolete
|
This is going to be merged into the DS 3.0 branch, not develop. We can use this feature branch leading up to tech debt week. We can then use part of TD week to merge it, make the release, and update rails-server |
|
@jasonbasuil @gabescarbrough bumping this. Nothing crazy going on here just some major version updates, but I want to get the ball rolling on DS 3.0 |
| @@ -1 +1 @@ | |||
| 18.18.2 | |||
| 20.12.1 | |||
| @@ -8,7 +8,6 @@ import 'scss/forms/input_label.scss'; | |||
|
|
|||
| const InputLabel = ({ | |||
| className, | |||
| elementType, | |||
There was a problem hiding this comment.
This prop isn't being used anywhere in rails-server either so that's good
Is the only non-feasible one Given react-toggle is unmaintained and has an issue from two years ago asking about React 18 with no replies I'd say we should look into moving away from that dependency |
|
Yea I believe the main offender was react toggle. IMO we can probably just replace it with some react code to do the same: |
This PR does the following: