Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vital from Alternatives list in an attempt to fix #101 #107

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

KTrain5169
Copy link
Contributor

note to self: nuke/remake the PR template

@KTrain5169 KTrain5169 linked an issue Oct 19, 2024 that may be closed by this pull request
Copy link

Deploying notessential with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cec864
Status: ✅  Deploy successful!
Preview URL: https://34de1414.website-5ff.pages.dev
Branch Preview URL: https://coi.website-5ff.pages.dev

View logs

@blryface blryface changed the title Goodbye Vital: Resolve conflict of interest? Remove Vital from Alternatives list in an attempt to fix #101 Oct 19, 2024
Copy link
Member

@blryface blryface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although the title could've been worded a lot better. This is why I edited it.

@KTrain5169
Copy link
Contributor Author

fair enough

do we merge or wait for pixel

@blryface
Copy link
Member

Pretty sure there's a specific reason why you made the Branch Protection Rule need me and pixel to approve it

@KTrain5169
Copy link
Contributor Author

KTrain5169 commented Oct 19, 2024

It doesn't, I just requested it myself

The protection rule only requires a successful deployment & a successful Prettier check

@blryface
Copy link
Member

seeing as pixel is probably busy around this time, I think we should just merge it.

@blryface blryface added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit b9a2a8f Oct 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict of interest?
2 participants