Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not Essential? #16

Closed
wants to merge 78 commits into from
Closed

Why not Essential? #16

wants to merge 78 commits into from

Conversation

KTrain5169
Copy link
Contributor

branch is also slightly outdated I think

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jul 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notessential ❌ Failed (Inspect) Jul 9, 2024 6:43am

@KTrain5169 KTrain5169 requested a review from blryface July 2, 2024 00:38
KTrain5169
KTrain5169 commented Jul 2, 2024
View reviewed changes
Copy link
Contributor Author

@KTrain5169 KTrain5169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting indenting currently

pages/info.vue Show resolved Hide resolved
pages/info.vue Show resolved Hide resolved
pages/info.vue Outdated Show resolved Hide resolved
pages/info.vue Outdated Show resolved Hide resolved
@KTrain5169
add: disclaimer & button to front page
fa9aba8 
I feel like the disclaimer will be needed...
@Gaming32
Copy link

Gaming32 commented Jul 3, 2024

I will note that Essential is not obfuscated in the slightest.

@KTrain5169
Copy link
Contributor Author

KTrain5169 commented Jul 3, 2024 via email •
edited
Loading

@KTrain5169 @blryface
add: start work on TL;DR on index
3570e9d 
forgot to mention that blryface sorta helped in the previous commits so tagging him here

Co-Authored-By: blryface <[email protected]>
@KTrain5169 KTrain5169 requested a review from blryface July 8, 2024 12:25
@blryface
Copy link
Member

blryface commented Jul 8, 2024

Will your branch being very outdated not cause issues?

blryface
blryface reviewed Jul 8, 2024
View reviewed changes
pages/index.vue Outdated Show resolved Hide resolved
blryface
blryface requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@blryface blryface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but try updating your branch to prevent issues with new features

@KTrain5169
Copy link
Contributor Author

KTrain5169 commented Jul 9, 2024 •
edited
Loading

Closing PR, this branch is way too big and messy LMAO

Development will now be moved to the 12-add-the-info-page branch on blryface/notessential

@KTrain5169 KTrain5169 closed this Jul 9, 2024
@KTrain5169 KTrain5169 deleted the why-not-essential branch July 9, 2024 09:23
@KTrain5169 KTrain5169 restored the why-not-essential branch July 11, 2024 08:02
@KTrain5169 KTrain5169 deleted the why-not-essential branch September 18, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blryface blryface blryface requested changes

@Nitrrine Nitrrine Nitrrine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KTrain5169 @Gaming32 @blryface @Nitrrine @worldwidepixel @intergrav