Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically check new commits with Prettier #23

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

Nitrrine
Copy link
Member

@Nitrrine Nitrrine commented Jul 5, 2024

Closes #22

Copy link

stackblitz bot commented Jul 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notessential ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 9:57am

Copy link
Contributor

@KTrain5169 KTrain5169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM but I have feedback for some improvement.

.github/workflows/prettier-check.yml Show resolved Hide resolved
.github/workflows/prettier-check.yml Outdated Show resolved Hide resolved
@KTrain5169
Copy link
Contributor

@blryface is there a way to tell Vercel not to deploy if the ONLY modified folders are ones that wouldn't affect what is seen on the website? (so .github/, .vscode/, README.md, LICENSE, etc...)?

Copy link
Contributor

@KTrain5169 KTrain5169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KTrain5169 KTrain5169 merged commit 4cb8902 into main Jul 5, 2024
4 checks passed
@Nitrrine Nitrrine deleted the feat/prettier-check branch July 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action to check commits and PRs if they were formatted with Prettier
2 participants