Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: content & code licenses #42

Merged
merged 2 commits into from
Aug 23, 2024
Merged

add: content & code licenses #42

merged 2 commits into from
Aug 23, 2024

Conversation

KTrain5169
Copy link
Contributor

@KTrain5169 KTrain5169 commented Aug 22, 2024

Category

  • Add mod to alternatives page
  • Site changes
  • Chore/documentation updates

Describe changes

Why did you do this?

As ZekeZ pointed out yesterday at the time of writing, NotEssential doesn't have a license. This particularly makes it hard for other projects if they want to use our website's information as they don't know what license they need to comply with.

Therefore, the proposal is as follows:

  • The original text on the website (for example, mod descriptions excluding that one Cosmetica quote) is licensed under CC-BY-SA 4.0. This license allows others to use the text on our website, as long as they credit us and ensure that adaptations are also licensed under this license.
  • The website code (that is, the code that powers the website) is licensed under GPL v3. This ensures that the website code can still be reused by anyone as long as they also follow the terms of GPL v3.

BREAKING CHANGES

  • Tick this box if you made changes that may or may not break site functionality.

What issues (if any) would this resolve?

Resolves #x

Any extra notes?

Checklist

  • I have put clear & concise details about the mod onto the page.
  • Links I have put in are all valid.
  • Mods added are not RATs.
  • I have clearly stated why I want this to be changed.
  • For major changes, I have clearly stated what they are and why I've done them.
  • Any new resources put in are safe and not malicious.
  • I have clearly explained why I have done this.
  • I have proofread the documentation changed and have ensured there are no spelling or grammatical errors.
  • (Workflow updates only) I have tested the workflow to ensure its functionality.
  • I have searched for duplicate PRs and have not found any.
  • I did not read this section.

Vercel will begin deploying to the Preview environment shortly after submitting this pull request. You may click on the "Visit Preview" link below to see a preview of what your changes look like.
If you updated only part of the repository such that it would not modify the website at all, you do not need to see the Vercel deployment.

You may also use the StackBlitz Codeflow button to quickview the PR in the browser and make changes at the same time if necessary.

Original text is licensed under CC-BY-SA 4.0
Website code is licensed under GPL v3

Co-Authored-By: Nitrrine <[email protected]>
Co-Authored-By: blryface <[email protected]>
Co-Authored-By: worldwidepixel <[email protected]>
Copy link

stackblitz bot commented Aug 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notessential ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 5:50am

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 22, 2024
@KTrain5169
Copy link
Contributor Author

how tf did that fail, it worked normal before and like, NOTHING CHANGED

Copy link
Member

@blryface blryface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text license can't be CC BY-SA because that would make projects that want to use our content required to use CC BY-SA too (according to ZekeZ)

@Gaming32
Copy link

That is what the SA means, yes. CC BY would not include the ShareAlike clause. CC BY only requires attribution.

@KTrain5169
Copy link
Contributor Author

KTrain5169 commented Aug 22, 2024 via email

Copy link
Member

@worldwidepixel worldwidepixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good?

@KTrain5169 KTrain5169 requested a review from blryface August 23, 2024 08:55
Copy link
Member

@blryface blryface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KTrain5169 KTrain5169 merged commit c629eac into main Aug 23, 2024
5 checks passed
@KTrain5169 KTrain5169 deleted the licensing branch August 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants