Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language names for Ukrainian & Russian #45

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

cutiegin
Copy link
Contributor

Pull request template

Category

  • Add mod to alternatives page
  • Site changes
  • Chore/documentation updates

Describe changes

“Changed the name of the Ukrainian language from ‘Українець’ to ‘Українська’, and changed ‘русский’ to ‘Русский’ because the name of the language starts with an uppercase letter.

Why did you do this?

The word “Українець” translates to “Ukrainian” in English. It refers to a Ukrainian person, a citizen of Ukraine. This noun is used to describe nationality.

BREAKING CHANGES

  • Tick this box if you made changes that may or may not break site functionality.

What issues (if any) would this resolve?

Correct language name: Changing “Українець” to “Українська” corrects the mistake, as “Українець” means “Ukrainian” (a person), while “Українська” is the correct name for the Ukrainian language.
Proper capitalization: Changing “русский” to “Русский” corrects the capitalization, as language names should start with an uppercase letter.
These changes ensure accuracy and adherence to the standard conventions for writing language names.

Any extra notes?

  • Consistency: Ensuring that all language names follow the same capitalization rules.
  • Clarity: Making sure that the names of languages are clear and unambiguous.
  • User Experience: Improving the user experience by providing accurate and correctly formatted language names.

Checklist

  • I have put clear & concise details about the mod onto the page.
  • Links I have put in are all valid.
  • Mods added are not RATs.
  • I have clearly stated why I want this to be changed.
  • For major changes, I have clearly stated what they are and why I've done them.
  • Any new resources put in are safe and not malicious.
  • I have clearly explained why I have done this.
  • I have proofread the documentation changed and have ensured there are no spelling or grammatical errors.
  • (Workflow updates only) I have tested the workflow to ensure its functionality.
  • I have searched for duplicate PRs and have not found any.
  • I did not read this section.

Vercel will begin deploying to the Preview environment shortly after submitting this pull request. You may click on the "Visit Preview" link below to see a preview of what your changes look like.
If you updated only part of the repository such that it would not modify the website at all, you do not need to see the Vercel deployment.

You may also use the StackBlitz Codeflow button to quickview the PR in the browser and make changes at the same time if necessary.

Copy link

stackblitz bot commented Aug 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Aug 26, 2024

@cutiegin is attempting to deploy a commit to the nugit's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the enhancement New feature or request label Aug 26, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! We've detected that this is your first PR here! If so, thank you! Please make sure everything in your template is correct and that you've reviewed our contributing guidelines, found here: https://notessential.blurryface.xyz/contributing

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
notessential ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 3:14pm

@blryface
Copy link
Member

lgtm ig I can't read either languages

@blryface blryface merged commit 3640880 into usevital:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants