-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crowdin stuff, pt 2 #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure if this is a mistake instead of using the Crowdin CLI but we'll see
gives me an excuse to try the action again
not sure if this would actually work as a fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Category
Describe changes
Added GitHub Action that automatically pulls from Crowdin and updates strings. Also adds a translation progress badge to README because why not?
Why did you do this?
Makes it easier to integrate with Crowdin. The current solution being used at StopMalwareContent (owned by Nitrrine) is apparently not the best? And using the CLI via
pnpm
may expose secrets.BREAKING CHANGES
What issues (if any) would this resolve?
Resolves #36
Extra notes?
This PR should not be merged until all secrets are set. The secrets that need to be set are the following:
contents: write
GITHUB_TOKEN should work, but if for some reason it doesn't (I can't test rn due to some factors namely requiring Crowdin strings to be not updated I think?) then a collaborator/owner of the repo needs to create a GitHub PAT with the scope selected.Checklist
Vercel will begin deploying to the Preview environment shortly after submitting this pull request. You may click on the "Visit Preview" link below to see a preview of what your changes look like.
If you updated only part of the repository such that it would not modify the website at all, you do not need to see the Vercel deployment.
You may also use the StackBlitz Codeflow button to quickview the PR in the browser and make changes at the same time if necessary.