Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise text in reasonsWhy, i18n support coming later #78

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

KTrain5169
Copy link
Contributor

@KTrain5169 KTrain5169 commented Sep 26, 2024

Pull request template

Category

  • Add mod to alternatives page
  • Site changes
  • Chore/documentation updates

Describe changes

Finalise the Why not Essential section. Coauthored with @worldwidepixel.

Why did you do this?

Many people have been requesting this to be finalised, so once this PR is finished this can be crossed off.

BREAKING CHANGES

  • Tick this box if you made changes that may or may not break site functionality.

What issues (if any) would this resolve?

Resolves #12

Any extra notes?

Checklist

  • I have put clear & concise details about the mod onto the page.
  • Links I have put in are all valid.
  • Mods added are not RATs.
  • I have clearly stated why I want this to be changed.
  • For major changes, I have clearly stated what they are and why I've done them.
  • Any new resources put in are safe and not malicious.
  • I have clearly explained why I have done this.
  • I have proofread the documentation changed and have ensured there are no spelling or grammatical errors.
  • (Workflow updates only) I have tested the workflow to ensure its functionality.
  • I have searched for duplicate PRs and have not found any.
  • I did not read this section.

Vercel will begin deploying to the Preview environment shortly after submitting this pull request. You may click on the "Visit Preview" link below to see a preview of what your changes look like.
If you updated only part of the repository such that it would not modify the website at all, you do not need to see the Vercel deployment.

You may also use the StackBlitz Codeflow button to quickview the PR in the browser and make changes at the same time if necessary.

Copy link
Contributor

Something went wrong when managing this PR! Maintainers, please check the Actions log for more details and potential fixes.

@github-actions github-actions bot added the enhancement New feature or request label Sep 26, 2024
pages/index.vue Outdated Show resolved Hide resolved
@worldwidepixel worldwidepixel marked this pull request as ready for review September 27, 2024 04:46
@worldwidepixel worldwidepixel marked this pull request as draft September 27, 2024 04:54
@worldwidepixel worldwidepixel marked this pull request as ready for review September 27, 2024 06:06
@worldwidepixel worldwidepixel self-requested a review September 27, 2024 06:06
Copy link
Member

@worldwidepixel worldwidepixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 very high quality steak

@KTrain5169 KTrain5169 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 233cda7 Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why not essential?
2 participants