Skip to content

Commit

Permalink
bump golangci-lint
Browse files Browse the repository at this point in the history
  • Loading branch information
ushitora-anqou committed Dec 4, 2024
1 parent 0f03126 commit b07565d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion common.mk
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ LOCALBIN ?= $(shell pwd)/bin
KUBERNETES_VERSION ?= 1.31.0
CONTROLLER_TOOLS_VERSION ?= v0.16.1
ENVTEST_VERSION ?= v0.19.0
GOLANGCI_LINT_VERSION ?= 1.59.1
GOLANGCI_LINT_VERSION ?= 1.62.2
KIND_VERSION ?= v0.24.0
HELM_VERSION ?= v3.15.4
YQ_VERSION ?= v4.44.3
Expand Down
6 changes: 0 additions & 6 deletions internal/controller/suite_test.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package controller_test

import (
"context"
"fmt"
"path/filepath"
"runtime"
Expand Down Expand Up @@ -29,8 +28,6 @@ var (
cfg *rest.Config
k8sClient client.Client
testEnv *envtest.Environment
ctx context.Context
cancel context.CancelFunc
)

func TestControllers(t *testing.T) {
Expand All @@ -42,8 +39,6 @@ func TestControllers(t *testing.T) {
var _ = BeforeSuite(func() {
logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))

ctx, cancel = context.WithCancel(context.TODO())

By("bootstrapping test environment")
testEnv = &envtest.Environment{
CRDDirectoryPaths: []string{filepath.Join("..", "..", "config", "crd", "bases")},
Expand Down Expand Up @@ -79,7 +74,6 @@ var _ = BeforeSuite(func() {

var _ = AfterSuite(func() {
By("tearing down the test environment")
cancel()
err := testEnv.Stop()
Expect(err).NotTo(HaveOccurred())
})
Expand Down

0 comments on commit b07565d

Please sign in to comment.