Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assessment objective label for PE-03(01) #212

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Rene2mt
Copy link
Contributor

@Rene2mt Rene2mt commented Sep 13, 2023

Committer Notes

This PR fixes a minor label typo for assessment objective PE-03(01)[02].

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

aj-stein-nist
aj-stein-nist previously approved these changes Sep 14, 2023
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will provisionally review this. Thanks for the catch. I will ask the rest of the team to review.

@aj-stein-nist aj-stein-nist added the bug The issue is a bug report. label Sep 14, 2023
wendellpiez
wendellpiez previously approved these changes Sep 14, 2023
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Interesting that we didn't find sooner. In principle we should validate to detect this kind of anomaly. Thanks indeed @Rene2mt.

@aj-stein-nist aj-stein-nist self-assigned this Sep 28, 2023
@aj-stein-nist
Copy link
Contributor

This is part of work for #116 and will be resolved along with it, moving it to Sprint 77.

@iMichaela
Copy link
Contributor

@aj-stein-nist - Do we have a reason for not merging this PR which has been reviewed and approved by 2 team members, and instead caring it into current sprint? I would like to merge it if there are bo blockers.

@aj-stein-nist
Copy link
Contributor

This is part of work for #116 and will be resolved along with it, moving it to Sprint 77.

It will be merged with #116, which is what is implied here, @iMichaela, or it will not work with the relevant CI/CD changes. I am very well aware of it, but thanks for reminding me.

@aj-stein-nist aj-stein-nist changed the base branch from main to develop October 24, 2023 21:02
@aj-stein-nist
Copy link
Contributor

TODO: I need to rebase before merge.

@aj-stein-nist aj-stein-nist changed the base branch from develop to main October 24, 2023 22:41
@aj-stein-nist aj-stein-nist dismissed stale reviews from wendellpiez and themself October 24, 2023 22:41

The base branch was changed.

@aj-stein-nist aj-stein-nist changed the base branch from main to develop October 24, 2023 23:08
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after rebase.

@aj-stein-nist aj-stein-nist merged commit bbde727 into usnistgov:develop Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug report.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants