-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assessment objective label for PE-03(01) #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will provisionally review this. Thanks for the catch. I will ask the rest of the team to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Interesting that we didn't find sooner. In principle we should validate to detect this kind of anomaly. Thanks indeed @Rene2mt.
This is part of work for #116 and will be resolved along with it, moving it to Sprint 77. |
@aj-stein-nist - Do we have a reason for not merging this PR which has been reviewed and approved by 2 team members, and instead caring it into current sprint? I would like to merge it if there are bo blockers. |
It will be merged with #116, which is what is implied here, @iMichaela, or it will not work with the relevant CI/CD changes. I am very well aware of it, but thanks for reminding me. |
TODO: I need to rebase before merge. |
The base branch was changed.
Co-Authored-By: Rene Tshiteya <[email protected]>
d72fa5c
to
ee2b993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after rebase.
Committer Notes
This PR fixes a minor label typo for assessment objective PE-03(01)[02].
All Submissions:
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?