Public-sans - POAM: September '24 #315
Conversation
There was a problem hiding this comment.
@mahoneycm thanks for the notes in the description. Hope you don't mind, I've modified the Important alert to state the workaround (last sentence - In the meantime I've downgraded ruby.
I've been able to successfully switch to Ruby 3.25 and do a clean install of both Node & Ruby dependencies without issues.
Tested using npm run serve and npm start.
October updatesDependency updates
Gem updates
|
Resuming review of this PR since we would have to wait for the next compile release to resolve |
| "@uswds/uswds": "3.8.1", | ||
| "gulp": "^4.0.2", | ||
| "@uswds/uswds": "3.9.0", | ||
| "gulp": "^5.0.0", |
There was a problem hiding this comment.
Tip
This major Gulp update has caused issues with fonts and images. I tested npm run copy-webfonts and didn't see any issues.
There was a problem hiding this comment.
I took a look at your work in uswds/uswds-compile#96 to make sure the issue that was captured and resolved there wasn't going to be an issue here! I didn't find any issues either 👍
| return src(`${WEBFONTS_SRC}/**/**`, { | ||
| encoding: false, | ||
| }).pipe(dest(WEBFONTS_DEST)); |
There was a problem hiding this comment.
Added to address the issue fixed in uswds/uswds-compile#96 from a solution noted in gulpjs/gulp#2803
Summary
POAM updates for September 2024
Warning
We received deprecation warnings for dependencies that are no longer supported. They are coming from USWDS compile and will be resolved in uswds/uswds-compile#122.
Important
This PR caught a Federalist build issue. The issue appears unrelated to these changes but was caught due to generating a new
gemfile.lock.The federalist pages team is investigating. Additional details in this slack thread (🔒).
In the meantime I've downgraded ruby.
Related issue
uswds/uswds-team#390
Resolves https://github.com/uswds/public-sans/security/dependabot/84
Resolves https://github.com/uswds/public-sans/security/dependabot/83
Resolves https://github.com/uswds/public-sans/security/dependabot/74
Resolves https://github.com/uswds/public-sans/security/dependabot/81
Resolves https://github.com/uswds/public-sans/security/dependabot/82
Preview link
Preview link →
Major changes
3.3.4to3.2.5to resolve Cloud Pages build error3.9.0Dependency updates
Before:
After
Dependency updates
Node package updates
Gem updates:
Testing and review
Gulp commands run without error
npm run startnpm run servenpm run test:a11y(while localhost is being served from the serve script)