Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Compile - POAM: June '24 #104

Merged
merged 5 commits into from
Jun 14, 2024
Merged

USWDS-Compile - POAM: June '24 #104

merged 5 commits into from
Jun 14, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Jun 10, 2024

Summary

POAM for June 2024.

Cleared dependency cache and rebuilt.

Dependency changes:

Before:

4 vulnerabilities (1 low, 3 moderate)

After:

3 moderate severity vulnerabilities

Testing instructions

  1. Install this branch on site
    • On Site's main branch, run:
npm install "https://github.com/uswds/uswds-compile/tree/cm-POAM-june-2024" --save
  1. Run gulp sass scripts and ensure compile runs as expected without error.
  2. Ensure no when package is used to compile site

Dependency updates

No direct dependency updates.

@mahoneycm mahoneycm mentioned this pull request Jun 10, 2024
1 task
@mahoneycm mahoneycm changed the title USWDS-Compiles - POAM: June '24 USWDS-Compile - POAM: June '24 Jun 10, 2024
@mdmower-csnw
Copy link
Contributor

Hint hint... those lingering 3 moderate severity vulnerabilities could be eliminated with #103. 😃

@mahoneycm mahoneycm requested review from mejiaj and amyleadem June 10, 2024 18:07
@mejiaj
Copy link
Contributor

mejiaj commented Jun 14, 2024

Thanks @mdmower-csnw! I've added myself and @mahoneycm as assignees to review and test.

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On npm audit --development I get the following:

14 vulnerabilities (3 moderate, 11 high)

Comment on lines +38 to +41
"sass-embedded": "1.77.5"
},
"devDependencies": {
"@uswds/uswds": "^3.8.0",
"@uswds/uswds": "^3.8.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in af019ea.

@mejiaj mejiaj merged commit 1b29ccd into develop Jun 14, 2024
1 check passed
@mejiaj mejiaj deleted the cm-POAM-june-2024 branch June 14, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants