Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Compile - Sass: Create quiet deprecations setting #131

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

USWDS-Compile - Sass: Create quiet deprecations setting #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
35b48cb
Create quietDeps setting
mahoneycm Nov 25, 2024
6d0329b
Update sass-embedded to test new deprecation warnings
mahoneycm Nov 25, 2024
ae7ffa0
Set default setting to true
mahoneycm Nov 25, 2024
23901df
Add quietSassDeps setting to settings table
mahoneycm Dec 9, 2024
1074780
Update README.md
mahoneycm Dec 10, 2024
7a4c434
Rename setting to sassDeprecationWarnings and update logic to be more…
mahoneycm Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,9 @@ Use path settings to customize where USWDS Compile looks for USWDS source and ou
| Setting | Default | Description |
| --------------------------------- | -------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `sprite.projectIconsOnly` | `false` | Include _only_ the icons in `paths.src.projectIcons` in the icon sprite. |
| `settings.compile.browserslist` | `["> 2%", "last 2 versions", "IE 11", "not dead"]` | Define the [browserslist query](https://github.com/browserslist/browserslist?tab=readme-ov-file#queries) for CSS prefixes generated by [autoprefixer](https://github.com/postcss/autoprefixer). |
| `settings.compile.browserslist` | `["> 2%", "last 2 versions", "IE 11", "not dead"]` | Define the [browserslist query](https://github.com/browserslist/browserslist?tab=readme-ov-file#queries) for CSS prefixes generated by [autoprefixer](https://github.com/postcss/autoprefixer). |
| `settings.compile.sassSourcemaps` | `true` | Include sourcemap when compiling SASS to CSS. |
| `settings.compile.sassDeprecationWarnings` | `false` | Show USWDS Sass deprecation warnings. When set to `true`, Sass will output deprecation warnings for USWDS code in the terminal during compilation. Deprecation warnings for non-USWDS Sass will output even when this value is set to `false`. |

### Functions

Expand Down
3 changes: 2 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ let settings = {
},
browserslist: ["> 2%", "last 2 versions", "IE 11", "not dead"],
sassSourcemaps: true,
sassDeprecationWarnings: false
},
sprite: {
width: 24,
Expand Down Expand Up @@ -198,7 +199,7 @@ function buildSass() {
sass({
outputStyle: "compressed",
includePaths: buildSettings.includes,
silenceDeprecations: ["mixed-decls"]
quietDeps: !settings.compile.sassDeprecationWarnings,
}).on("error", handleError)
)
.pipe(replace(/\buswds @version\b/g, `based on uswds v${pkg}`))
Expand Down
Loading
Loading