Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require.resolve() to find the uswds package path #76

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Use require.resolve() to find the uswds package path #76

merged 2 commits into from
Nov 15, 2023

Conversation

danielnaab
Copy link
Contributor

This PR fixes #75, making gulp-compile compatible with pnpm and any package manager that may have a local package cache.

@mejiaj mejiaj added the Status: Triage We're triaging this issue and grooming if necessary label Nov 8, 2023
@mejiaj
Copy link
Contributor

mejiaj commented Nov 8, 2023

@danielnaab thanks for submitting this!

I've added the triage label so we can review and prioritize in our next triage meeting.

@mejiaj mejiaj removed the Status: Triage We're triaging this issue and grooming if necessary label Nov 13, 2023
@mejiaj mejiaj self-assigned this Nov 13, 2023
@mejiaj mejiaj self-requested a review November 13, 2023 18:27
mejiaj
mejiaj approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitted this, confirming it works on my M1 Mac using pnpm v8.10.4.

How I tested

  1. Go to uswds/uswds-sandbox repo.
  2. Install compile version of feature branch pnpm add "uswds/uswds-compile#danielnaab-package-json-paths".
  3. Run buildSass task pnpm run uswds:buildSass.
  4. Confirm compile works properly.

Also, tested with regular NPM and found no regressions.

@mejiaj mejiaj removed their assignment Nov 13, 2023
thisisdano
thisisdano approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thisisdano thisisdano merged commit eff4198 into uswds:develop Nov 15, 2023
@thisisdano thisisdano mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano thisisdano approved these changes

@mejiaj mejiaj mejiaj approved these changes

@mahoneycm mahoneycm Awaiting requested review from mahoneycm

@amyleadem amyleadem Awaiting requested review from amyleadem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USWDS-Compile - Bug: pnpm support
3 participants
@danielnaab @mejiaj @thisisdano