build.rs: also search for library files in lib64/ #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bonus points to add an error message to the assert_eq. Otherwise looks great. Thanks for the PR. I will merge once tests look mostly green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compilation on my machine and in Nix.
It seems like
libllama.aends up in${out_dir}/lib64/, and not in${out_dir}/lib/, like the build script assumes.Why? I'm not quite sure. But it hapens on the current nixos-unstable, using cargo, cmake and clang from nixpkgs.
It also affects building in the nix build sandbox (using e.g.
nixpkgs.rustPlatofrm.buildRustPackage), so after this patch it is again possible to build rust applications that depend on this library using the nix build system.