This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
added IP address retrieval #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 41774c2 into fe061f4 - view on LGTM.com new alerts:
This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
tygamvrelis
reviewed
Jun 29, 2019
| @@ -763,6 +767,25 @@ void print_ip_address(char ip_address[]){ | |||
|
|
|||
|
|
|||
| int main(){ | |||
| int result = system("python ip_address.py 1"); | |||
| int arraysize=14; | |||
| char ip[arraysize]; | |||
There was a problem hiding this comment.
Is 14 always going to be large enough for the IP address? Maybe std::string could work better here
| int result = system("python ip_address.py 1"); | ||
| int arraysize=14; | ||
| char ip[arraysize]; | ||
| char current_char; |
There was a problem hiding this comment.
Are you using all these local variables? If not, you can remove them
rfairley
reviewed
Jul 1, 2019
| @@ -763,6 +767,25 @@ void print_ip_address(char ip_address[]){ | |||
|
|
|||
|
|
|||
| int main(){ | |||
| int result = system("python ip_address.py 1"); | |||
There was a problem hiding this comment.
Does the 1 need to be passed in here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.