feat: add submit example with refactor of common functions #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf31o2
requested changes
Jul 2, 2024
main.go
Outdated
| var client UtxorpcClient | ||
| chainSyncClient := syncconnect.NewChainSyncServiceClient(httpClient, baseUrl, connect.WithGRPC()) | ||
| queryClient := queryconnect.NewQueryServiceClient(httpClient, baseUrl, connect.WithGRPC()) | ||
| submitClient := submitconnect.NewSubmitServiceClient(httpClient, baseUrl, connect.WithGRPC()) | ||
| watchClient := watchconnect.NewWatchServiceClient(httpClient, baseUrl, connect.WithGRPC()) | ||
| client.httpClient = httpClient | ||
| client.baseUrl = baseUrl | ||
| client.apiKey = apiKey |
There was a problem hiding this comment.
This is currently implementation-specific (demeter) and isn't required by UTxO RPC. This should be a more generic "request headers" implementation if it's going into the main SDK code.
verbotenj
force-pushed
the
feat/submit-examxample
branch
2 times, most recently
from
2248c28 to
4118be9
Compare
wolf31o2
requested changes
Jul 2, 2024
main.go
Outdated
| client.Query = queryClient | ||
| client.Submit = submitClient | ||
| client.Watch = watchClient | ||
| type ClientOptinon func(*UtxorpcClient) |
There was a problem hiding this comment.
typo... ClientOption (across file)
Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat/submit-examxample
branch
from
4118be9 to
1125e27
Compare
wolf31o2
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes #10