Google code issue 140: org.jsmpp.bean.OptionalParameter.COctetString.…

…getValueAsString() returns a String which miss the last character
uudashr · Sep 1, 2013 · dfccd92 · dfccd92
1 parent 9c9c28a
commit dfccd92
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/jsmpp/src/main/java/org/jsmpp/bean/OptionalParameter.java b/jsmpp/src/main/java/org/jsmpp/bean/OptionalParameter.java
@@ -270,8 +270,7 @@ public COctetString(short tag, byte[] value) {
 
         @Override
         public String getValueAsString() {
-            byte[] value = getValue();
-            return new String(value, 0, value.length - 1);
+            return new String(getValue());
         }
 
     }

diff --git a/jsmpp/src/test/java/org/jsmpp/bean/OptionalParameterTest.java b/jsmpp/src/test/java/org/jsmpp/bean/OptionalParameterTest.java
@@ -20,6 +20,10 @@
 import static org.testng.Assert.assertNull;
 import static org.testng.Assert.fail;
 
+import java.io.UnsupportedEncodingException;
+import java.nio.charset.Charset;
+
+import org.jsmpp.bean.OptionalParameter.COctetString;
 import org.jsmpp.bean.OptionalParameter.Callback_num_pres_ind.Presentation_Indicator;
 import org.jsmpp.bean.OptionalParameter.Callback_num_pres_ind.Screening_Indicator;
 import org.jsmpp.bean.OptionalParameter.Ms_msg_wait_facilities;
@@ -144,4 +148,11 @@ public void Network_error_code() {
 		assertEquals(o.getErrorCode(), (short)60000);
 
 	}
+
+    @Test(groups="checkintest")
+    public void cOctetStringGetValueAsString() throws UnsupportedEncodingException {
+        COctetString string = new OptionalParameter.COctetString(Tag.ADDITIONAL_STATUS_INFO_TEXT.code(), "urgent");
+
+        assertEquals(string.getValueAsString(), "urgent");
+    }
 }