Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update actions to run on Node 16 #4157

Merged
merged 4 commits into from
Nov 19, 2022
Merged

CI: update actions to run on Node 16 #4157

merged 4 commits into from
Nov 19, 2022

Conversation

miles170
Copy link
Contributor

@miles170 miles170 commented Nov 18, 2022 •
edited
Loading

Closes #4154.

  1. remove use of actions-rs/cargo

actions-rs/cargo is currently inactive and has an issue like actions-rs/cargo#216

  1. remove use of actions-rs/toolchain

actions-rs/toolchain is currently inactive and has an issue like actions-rs/toolchain#219

  1. Swatinem/rust-cache should happen after the toolchain. See https://github.com/Swatinem/rust-cache
  2. fix rust-cache cache conflict. See Post Run Swatinem/rust-cache@v2
  3. replace actions-rs/install with cargo install, since with Swatinem/rust-cache the binary can be cached

actions-rs/install is currently inactive and has an issue like actions-rs/toolchain#219

@miles170 miles170 marked this pull request as draft November 18, 2022 06:27
@miles170 miles170 force-pushed the ci-update-actions branch 2 times, most recently from 71fba44 to f010ada Compare November 18, 2022 06:58
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!

2 similar comments
@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/tee is no longer failing!

@miles170 miles170 marked this pull request as ready for review November 19, 2022 09:49
@miles170
Copy link
Contributor Author

Check CI here:

  1. CICD
  2. GnuTests

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/rm/ext3-perf. tests/rm/ext3-perf is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@sylvestre sylvestre merged commit e6ff094 into uutils:main Nov 19, 2022
@sylvestre
Copy link
Contributor

thanks!

@miles170 miles170 deleted the ci-update-actions branch November 19, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swatinem/rust-cache is causing warnings in the CI
2 participants
@miles170 @sylvestre