Skip to content

Commit

Permalink
Merge pull request #95 from uweb/Youtube-
Browse files Browse the repository at this point in the history
Accessibility issues - YouTube iframe
  • Loading branch information
lcaple authored Mar 27, 2018
2 parents 4a30da6 + d1e6176 commit 27f25a5
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion js/site.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -11983,7 +11983,7 @@ UW.YouTube.CollectionView = Backbone.View.extend({
// if we don't have a copy of the youtube iframe api yet. add it
add_iFrame_api: function () {
if (UW.$body.find('script#iFrame').length === 0){
UW.$body.append('<script id="iFrame" src="//www.youtube.com/player_api" type="text/javascript"></script>');
UW.$body.append('<script id="iFrame" title="YouTube video player" src="//www.youtube.com/player_api" type="text/javascript"></script>');
this.add_iFrame_function();
}
},
Expand Down
2 changes: 1 addition & 1 deletion js/site.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/uw.js
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ UW.YouTube.CollectionView = Backbone.View.extend({

add_iFrame_api: function () {
if (UW.$body.find('script#iFrame').length === 0){
UW.$body.append('<script id="iFrame" src="//www.youtube.com/player_api" type="text/javascript"></script>');
UW.$body.append('<script id="iFrame" title="YouTube video player" src="//www.youtube.com/player_api" type="text/javascript"></script>');
this.add_iFrame_function();
}
},
Expand Down Expand Up @@ -954,7 +954,7 @@ UW.Vimeo = Backbone.View.extend({
// The first one is the standard Vimeo iFrame which is used for both single and playlist driven embeds.
// The second one is the playlist and only shows if a playlist is being called.
templates : {
video : '<iframe id="test" src="http://player.vimeo.com/video/<%= video %>/?<%= $.param( defaults ) %>"' +
video : '<iframe id="test" title="Vimeo video player" src="http://player.vimeo.com/video/<%= video %>/?<%= $.param( defaults ) %>"' +
' width=<%= width %> height=<%= height %>'+
// ' frameborder=0 webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>',
'style="border:0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>',
Expand Down
2 changes: 1 addition & 1 deletion js/uw.youtube.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ UW.YouTube.CollectionView = Backbone.View.extend({
// if we don't have a copy of the youtube iframe api yet. add it
add_iFrame_api: function () {
if (UW.$body.find('script#iFrame').length === 0){
UW.$body.append('<script id="iFrame" src="//www.youtube.com/player_api" type="text/javascript"></script>');
UW.$body.append('<script id="iFrame" title="YouTube video player" src="//www.youtube.com/player_api" type="text/javascript"></script>');
this.add_iFrame_function();
}
},
Expand Down
2 changes: 1 addition & 1 deletion uw.js

Large diffs are not rendered by default.

0 comments on commit 27f25a5

Please sign in to comment.