Take string as reference

uxlfoundation · Jul 18, 2024 · 75b4c4a · 75b4c4a
1 parent 6b4678f
commit 75b4c4a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/sparse_blas/backends/cusparse/operations/cusparse_spmv.cpp b/src/sparse_blas/backends/cusparse/operations/cusparse_spmv.cpp
@@ -58,7 +58,7 @@ inline auto get_cuda_spmv_alg(spmv_alg alg) {
     }
 }
 
-void check_valid_spmv(const std::string function_name, sycl::queue &queue,
+void check_valid_spmv(const std::string &function_name, sycl::queue &queue,
                       oneapi::mkl::transpose opA, oneapi::mkl::sparse::matrix_view A_view,
                       oneapi::mkl::sparse::matrix_handle_t A_handle,
                       oneapi::mkl::sparse::dense_vector_handle_t x_handle,

diff --git a/src/sparse_blas/backends/mkl_common/mkl_spmm.cxx b/src/sparse_blas/backends/mkl_common/mkl_spmm.cxx
@@ -29,7 +29,7 @@ sycl::event release_spmm_descr(sycl::queue &queue, oneapi::mkl::sparse::spmm_des
     return detail::collapse_dependencies(queue, dependencies);
 }
 
-void check_valid_spmm(const std::string function_name, sycl::queue &queue,
+void check_valid_spmm(const std::string &function_name, sycl::queue &queue,
                       oneapi::mkl::transpose opA, oneapi::mkl::sparse::matrix_view A_view,
                       oneapi::mkl::sparse::matrix_handle_t A_handle,
                       oneapi::mkl::sparse::dense_matrix_handle_t B_handle,

diff --git a/src/sparse_blas/backends/mkl_common/mkl_spsv.cxx b/src/sparse_blas/backends/mkl_common/mkl_spsv.cxx
@@ -29,7 +29,7 @@ sycl::event release_spsv_descr(sycl::queue &queue, oneapi::mkl::sparse::spsv_des
     return detail::collapse_dependencies(queue, dependencies);
 }
 
-void check_valid_spsv(const std::string function_name, sycl::queue &queue,
+void check_valid_spsv(const std::string &function_name, sycl::queue &queue,
                       oneapi::mkl::sparse::matrix_view A_view,
                       oneapi::mkl::sparse::matrix_handle_t A_handle,
                       oneapi::mkl::sparse::dense_vector_handle_t x_handle,

diff --git a/src/sparse_blas/common_op_verification.hpp b/src/sparse_blas/common_op_verification.hpp
@@ -45,7 +45,7 @@ void check_ptr_is_host_accessible(const std::string &function_name, const std::s
 }
 
 template <typename InternalSparseMatHandleT>
-void check_valid_spmm_common(const std::string function_name, sycl::queue &queue,
+void check_valid_spmm_common(const std::string &function_name, sycl::queue &queue,
                              oneapi::mkl::sparse::matrix_view A_view,
                              InternalSparseMatHandleT internal_A_handle,
                              oneapi::mkl::sparse::dense_matrix_handle_t B_handle,
@@ -82,7 +82,7 @@ void check_valid_spmm_common(const std::string function_name, sycl::queue &queue
 }
 
 template <typename InternalSparseMatHandleT>
-void check_valid_spmv_common(const std::string function_name, sycl::queue &queue,
+void check_valid_spmv_common(const std::string &function_name, sycl::queue &queue,
                              oneapi::mkl::transpose opA, oneapi::mkl::sparse::matrix_view A_view,
                              InternalSparseMatHandleT internal_A_handle,
                              oneapi::mkl::sparse::dense_vector_handle_t x_handle,
@@ -124,7 +124,7 @@ void check_valid_spmv_common(const std::string function_name, sycl::queue &queue
 }
 
 template <typename InternalSparseMatHandleT>
-void check_valid_spsv_common(const std::string function_name, sycl::queue &queue,
+void check_valid_spsv_common(const std::string &function_name, sycl::queue &queue,
                              oneapi::mkl::sparse::matrix_view A_view,
                              InternalSparseMatHandleT internal_A_handle,
                              oneapi::mkl::sparse::dense_vector_handle_t x_handle,