[CMake] Remove FindRoc* files #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test to build this with CMake 1.13, the minimum version required by the root CMakeLists.txt? It occurred to me just now that older version of CMake may not be able to find these packages. |
It didn't occur to me to do this. I've now built the library (tests disabled), and it builds with this patch with 3.13. |
Rbiessy
approved these changes
May 29, 2024
mkrainiuk
approved these changes
May 29, 2024
Rbiessy
approved these changes
May 31, 2024
dnhsieh-intel
approved these changes
May 31, 2024
2 tasks
Rbiessy
pushed a commit
to Rbiessy/oneMath
that referenced
this pull request
Jun 7, 2024
* Some files are deleted. * These files were not needed, but added potential for issues. * Eg. if HIP_PATH was not set, the shared library associated with the target would not be found.
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
* Some files are deleted. * These files were not needed, but added potential for issues. * Eg. if HIP_PATH was not set, the shared library associated with the target would not be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the files Findroc* to remove complexity. Additionally, it resolves an issue where HIP is not installed at the default location given by
HIP_PATH. If the (as far as I now) undocumentedHIP_PATHis not set, the build system (make, ninja) produces an error when the.sofile is not found in the expected location.The version in this PR seems to find the ROCm maths libraries by default and reduce the amount of CMake that we need to maintain.
The need for the files being deleted was not clear to me. Deleting them seemed like the most simple fix for the above issue, but we could also check the shared library exists and generate an error in the CMake instead.
Checklist
All Submissions
testrng.txt
lapackres.txt
rocblas_test.log