[CI] Enable clang-format check #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Rbiessy
reviewed
Oct 15, 2024
mkrainiuk
approved these changes
Oct 18, 2024
dnhsieh-intel
force-pushed
the
pre-commit
branch
from
71626a2 to
64f17b4
Compare
|
@Rbiessy I am merging the PR in case other commits get between this one and the reformatting. I will open a new one if you have suggested changes. |
|
I had no concerns with this PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the discussion in issue #580, this PR adds a job in CI to check code formatting using
pre-commitwith clang-format v19.1.0.This PR will be rebased after PR #594 is merged. We should have a green clang-format check then.
Fixes #580
Checklist
All Submissions