This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Mineral 0.48.0 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcintreder
commented
Oct 19, 2018
marcintreder
commented
- Update of Mineral to 0.48.0
- Necessary fixes to make the new version work with Merge (change in UXPinWrapper)
- Added two new components – Tabs and Table
- Mark Dialog & Table as in-development
* flow-to-prop-types babel plugin does not allow props to be destructured in function declaration (errors were not rendered to the console)
* flow-to-prop-types babel plugin does not allow props to be destructured in function declaration (errors were not rendered to the console) * assign default props after function declaration to match component pattern
* Adds dev-only types example to TextInput demo
Co-authored-by: Mike Holm <[email protected]> BREAKING CHANGE: See our Emotion migration guide for details. https://github.com/mineral-ui/mineral-ui/blob/master/docs/emotion-migration.md
Co-authored-by: Mike Holm <[email protected]>
Co-authored-by: Mike Holm <[email protected]>
Recently, I've been working on making Happo runs work for PRs coming from forks. Version 1.5.0 of the happo.io client has support for temporary authentication tied to a specific PR on github. This is helpful when running happo in CI (Travis/CircleCI/etc) because in general, secret environment variables aren't sent to the job running for the fork (for obvious reasons: anyone would be able to extract secrets).
Since [email protected] (which is the version used on mineral-ui master), `apiKey` and `apiSecret` are no longer needed for builds triggered by a PR. Instead, a separate auth mechanism kicks in to allow the happo run to succeed. The authentication used here is limited in scope (only allowed on specific commit shas) and in time (has a short ttl). In most scenarios, the limited authentication is enough. There are edge-cases however, where the happo run might fail unexpectedly. Some of the cases where this can happen: - Re-triggering a happo build when no code change has been made to the PR - Long wait times from CI causing tokens to time out. A pre-requisite for token-less authentication to work is that the Happo Github App is installed and properly configured on https://happo.io/github-integration (I've already done this, so no need for action here).
… additional changes * Remove pointer events from Button internal content * Zero margins for Button * Closes #707 * Update tests for all other components effected: Card, Dropdown, Form, Link, Popover, Select, Text, TextArea, TextInput, and Tooltip Co-authored-by: Brent Ertz <[email protected]> BREAKING CHANGES: Remove ‘regular’ variant
Co-Authored-By: Brent Ertz <[email protected]>
Co-Authored-By: Brent Ertz <[email protected]>
Co-Authored-By: Brent Ertz <[email protected]> Co-Authored-By: kylegach <[email protected]> Co-Authored-By: Mike Holm <[email protected]>
Co-Authored-By: Brent Ertz <[email protected]> Co-Authored-By: kylegach <[email protected]>
Co-Authored-By: Brent Ertz <[email protected]>
* Refactor OverflowContainerWithShadows to place shadows _over_ the overflowed content and apply in x & y axes * Remove style reset from Popover root
* Programatically wrap Tooltip around truncated content
* Fix an icon placement issue in DocPractice * Update component status
* Default Button styles * Disabled styles
* Button: default styles and implement new RTL property pattern
* ButtonGroup affected mainly due to new focus styles with border colors
* Implement new RTL property pattern
* Add comments for complex selectors
* MenuItem affected due to tokens change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.