Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make salt-broker reconnecting on master IP change #9074

Merged

Conversation

vzhestkov
Copy link
Contributor

@vzhestkov vzhestkov commented Jul 19, 2024

What does this PR change?

In some cases salt-broker could got stuck trying to connect to the salt-master with the old IP address of it, in case if IP address of the master has changed.

This fix is making salt-broker more agressive on re-resolving IP address.

GUI diff

No difference.

Documentation

  • No documentation needed: only internal and user invisible changes

Test coverage

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Tracks: https://github.com/SUSE/spacewalk/issues/24752, https://github.com/SUSE/spacewalk/issues/24871
Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@vzhestkov vzhestkov force-pushed the make-salt-broker-master-ip-change branch from 70a8f28 to 8eeb982 Compare November 25, 2024 15:49
@vzhestkov vzhestkov merged commit bdaa1a2 into uyuni-project:master Nov 26, 2024
16 checks passed
Copy link
Contributor

⚠️ Some changelog tests have failed. @vzhestkov, please review and fix the changelog issues with an additional PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants