Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container with vscode/Intellij configuration #9496

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mbussolotto
Copy link
Member

@mbussolotto mbussolotto commented Nov 20, 2024

What does this PR change?

https://github.com/uyuni-project/uyuni/wiki/Working-with--Uyuni-Project-Using-DevContainers

GUI diff

No difference.

  • DONE

Documentation

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mbussolotto mbussolotto requested review from a team as code owners November 20, 2024 01:49
@mbussolotto mbussolotto requested review from nadvornik and removed request for a team November 20, 2024 01:49
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9496/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9496/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request

@srbarrios
Copy link
Member

If we can support IntelliJ too, I will be super grateful. 😊

@mbussolotto mbussolotto marked this pull request as draft November 20, 2024 14:18
@mbussolotto
Copy link
Member Author

If we can support IntelliJ too, I will be super grateful. 😊

this is the plan for the rest of the hackweek, improve IDE support. Unfortuntately IntelliJ Community doesn't support dev container (just IntelliJ Ultimate...and when I tested it didn't work), but I'll look if there's any workaround

@mbussolotto mbussolotto marked this pull request as ready for review November 20, 2024 16:23
@srbarrios
Copy link
Member

If we can support IntelliJ too, I will be super grateful. 😊

this is the plan for the rest of the hackweek, improve IDE support. Unfortuntately IntelliJ Community doesn't support dev container (just IntelliJ Ultimate...and when I tested it didn't work), but I'll look if there's any workaround

I have a IntelliJ Ultimate account (educational pack), if you want that I try it, let me know.

@mbussolotto mbussolotto requested a review from a team as a code owner November 22, 2024 01:20
@mbussolotto
Copy link
Member Author

The last two commit should have improve the IDE configuration (in vscode and intellij)...maybe now everything would be configured out of the box. If not, we can improve the configuration file

@cbbayburt
Copy link
Contributor

Thanks, @mbussolotto! On top of this, also please consider adding a section in the wiki pages for devs.

@mbussolotto
Copy link
Member Author

@cbbayburt documentation is my plan for today, so probably would be ok by the end of this hackweek ;)

@mbussolotto mbussolotto changed the title Dev container with vscode configuration Dev container with vscode/Intellij configuration Nov 22, 2024
@mbussolotto mbussolotto requested review from a team and m-czernek and removed request for a team November 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants