remove todo

uzh · Aug 15, 2023 · cc40376 · cc40376
1 parent facb1e4
commit cc40376
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pool/app/contact_counter/contact_counter.ml b/pool/app/contact_counter/contact_counter.ml
@@ -6,6 +6,7 @@ let update_on_session_signup m sessions =
 
 let update_on_assignment_from_waiting_list = update_on_session_signup
 
+(* TODO: Only update counters when session is closed? *)
 let update_on_session_closing
   contact
   no_show

diff --git a/pool/cqrs_command/assignment_command.ml b/pool/cqrs_command/assignment_command.ml
@@ -288,17 +288,15 @@ end = struct
     participated_in_other_assignments
     { no_show; participated; external_data_id }
     =
-    (* TODO: Only update counters when session is closed? *)
     Logs.info ~src (fun m -> m "Handle command Update" ~tags);
     let open CCResult in
     let open Assignment in
-    let assignment, no_show, _ =
+    let assignment =
       { assignment with
         no_show = Some no_show
       ; participated = Some participated
       ; external_data_id
       }
-      |> set_close_default_values (* TODO: Remove? *)
     in
     let* () =
       validate experiment assignment