Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/320 external data #181

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Feature/320 external data #181

merged 9 commits into from
Aug 8, 2023

Conversation

mabiede
Copy link
Contributor

@mabiede mabiede commented Aug 7, 2023 •
edited
Loading

  • add external_data_id_required to experiments
  • add external_data_id to assignments (required latest on session close)
  • hide contact information when not allowed to read it
  • split first-/lastname of contact information list in session assignments
  • fix additional externalize of redirect

@mabiede mabiede requested a review from timohuber August 7, 2023 10:48
timohuber
timohuber requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@timohuber timohuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • make sure not to ask for "external_data_id" when it is not required (or just not required)
  • do not allow empty strings

@timohuber timohuber merged commit d0f8848 into main Aug 8, 2023
5 checks passed
@timohuber timohuber deleted the feature/320-external-data branch August 8, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timohuber timohuber timohuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabiede @timohuber