-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dx: reproducible local env #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran into an issue with Debian-10 on macOS M1 (although not clear if the os/arch has anything to do with this), where the latest version of Parcel tried to pull in Rust-based components that relied on libc 2.29 or higher. Unfortunately Debian 10 ships with libc 2.28, so this crashed at runtime. This should be enough to fix it.
5 tasks
mabiede
requested changes
Nov 17, 2023
fix(ci): use new env variable for first tenant db fix(ci): we need both env vars now fix(ci): move away from TENANT_TEST
leostera
force-pushed
the
dx/reproducible-local-env
branch
from
November 17, 2023 12:01
a494cb1
to
5fa0794
Compare
mabiede
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋🏼
After a lot of struggles with DevContainers and VS Code, I resolved to fix the environment issues I had to be able to run the app, and run the tests, locally, using the tools that I'm most comfortable with.
It took some energy, but this PR does:
Move away from
nocrypto
and ontomirage-crypto
–nocrypto
has been deprecated and hasn't received any updates for ~5 years, and is considered a security concern.mirage-crypto
is its successor, and gets a lot of attention. To do this I had to fork Sihl, so you'll find that we're pinning it now to: leostera/sihl@ef4c89f – I've also opened a PR to Sihl upstreaming these changes: feat: move away from nocrypto oxidizing/sihl#563Bump the version of Debian we are using. I was tempted to move to Ubuntu 23.04 (or one of the LTS versions they still offer support for), but Debian 12 includes a recent-enough version of OpenSSL (~3).
Include phpMyAdmin as a side to Adminer, since Adminer does not support logging into databases without a password (and currently both our development databases are passwordless).
Include an
esy.json
manifest for reproducible builds on macOS using Esy – this is the large set of folders you see there. They are mostly inoffensive and act as a lock file. In the meantime, I've deleted thedefault.nix
file that is unmaintained and doesn't run on modern versions of Nix and NixPkgs.Refactor code accordingly and make sure all the tests are still passing both on the DevContainers setup and in the Local setup.