Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2219 changelog #411

Closed
wants to merge 32 commits into from
Closed

Feature/2219 changelog #411

wants to merge 32 commits into from

Conversation

timohuber
Copy link
Contributor

No description provided.

@timohuber timohuber requested a review from mabiede August 9, 2024 06:11
@timohuber timohuber marked this pull request as draft August 9, 2024 06:11
@timohuber timohuber removed the request for review from mabiede August 9, 2024 06:12
@timohuber timohuber requested a review from mabiede August 14, 2024 14:08
pool/app/changelog/changelog.ml Outdated Show resolved Hide resolved
pool/app/changelog/changelog.ml Outdated Show resolved Hide resolved
(before : R.t)
(after : R.t)
=
(*** the entity_uuid could also be part of the Reord module, as a function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(*** the entity_uuid could also be part of the Reord module, as a function.
(*** the entity_uuid could also be part of the Record module, as a function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is still a WIP note 😄
Still not sure if it is more convenient to use the Entity module (https://github.com/uzh/z-pool-tool/blob/feature/2219-changelog/pool/app/pool_location/version_history.ml) or to create e separate Record module.

pool/app/changelog/entity.ml Outdated Show resolved Hide resolved
pool/app/changelog/repo/repo_entity.ml Outdated Show resolved Hide resolved
pool/app/changelog/repo/repo_entity.ml Outdated Show resolved Hide resolved
pool/app/organisational_unit/organisational_unit.mli Outdated Show resolved Hide resolved
pool/app/pool_location/entity.ml Outdated Show resolved Hide resolved
pool/app/pool_location/pool_location.mli Outdated Show resolved Hide resolved
@timohuber timohuber closed this Sep 24, 2024
@timohuber timohuber deleted the feature/2219-changelog branch November 26, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants