Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap quill patched with Safari polyfill, add value property #14

Merged
merged 11 commits into from
Oct 8, 2018

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Oct 4, 2018

Fixes #2

For now there are 2 main problems and both are related to the select controls:

  • in Safari polyfilled selection does not apply
  • in all the Shady DOM browers (Firefox 62, Edge, IE11) style scope does not apply

However, at least the normal button controls are confirmed to work. So let's start with something like that and consider a proper fix for select controls to be added later.

Note: PR includes a built Quill version with a patched polyfill. This should be suitable for MVP but we have to revisit it before 1.0.0 stable release.


This change is Reviewable

Copy link
Member Author

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion

a discussion (no related file):
WIP, do not merge please. Blocking this PR to prevent merging by accident.


@web-padawan web-padawan changed the title WIP: wrap quill, patched version with getSelection [skip ci] Wrap quill patched version with Safari polyfill, add value Oct 5, 2018
@web-padawan web-padawan changed the title Wrap quill patched version with Safari polyfill, add value Wrap quill patched with Safari polyfill, add value property Oct 5, 2018
Copy link
Member Author

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now ready for review. Integrating Quill as a dependency is a subject to another discussion.

Reviewable status: 0 of 12 files reviewed, all discussions resolved

@web-padawan
Copy link
Member Author

Note: changes to quill can be reviewed at slab/quill#2337

Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Not blockers:
  • We can think about ways of setting Quill as the dependency, like it was described previously.

  • We can try to implement our own lumo theme to be used instead of snow which brings quite a lot of non-clear css to the wc.

Reviewed 1 of 5 files at r1, 11 of 12 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @web-padawan)


src/vaadin-rich-text-editor.html, line 108 at r2 (raw file):

            value: {
              type: Object,
              readOnly: true,

Should be writable.


test/basic.html, line 151 at r2 (raw file):

        });

        it('should be read only and disallow modifications', () => {

Should be updated once value becomes writable.

Copy link
Member Author

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on @YuriyVaadin)


src/vaadin-rich-text-editor.html, line 108 at r2 (raw file):

Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…

Should be writable.

Done.


test/basic.html, line 151 at r2 (raw file):

Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…

Should be updated once value becomes writable.

Done.

Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@tomivirkki tomivirkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1, 5 of 12 files at r2, 6 of 6 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tomivirkki tomivirkki merged commit a022f40 into master Oct 8, 2018
@tomivirkki tomivirkki deleted the proto/wrap-quill branch October 8, 2018 14:43
@aadamsx
Copy link

aadamsx commented Oct 8, 2018

This is now 100%? I can start using Quill in my LitElement components and still be in Shadow-DOM?

@tomivirkki
Copy link
Member

@aadamsx We released version 1.0.0-alpha2 yesterday. Here's an example of it being used with lit element https://glitch.com/edit/#!/ritzy-bill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap Quill and add value property
4 participants