-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap quill patched with Safari polyfill, add value property #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
a discussion (no related file):
WIP, do not merge please. Blocking this PR to prevent merging by accident.
df44567
to
1081281
Compare
865db94
to
6fa85af
Compare
3eb8add
to
b0238ce
Compare
b0238ce
to
ba71e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now ready for review. Integrating Quill as a dependency is a subject to another discussion.
Reviewable status: 0 of 12 files reviewed, all discussions resolved
Note: changes to quill can be reviewed at slab/quill#2337 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
We can think about ways of setting Quill as the dependency, like it was described previously.
-
We can try to implement our own
lumo
theme to be used instead ofsnow
which brings quite a lot of non-clear css to the wc.
Reviewed 1 of 5 files at r1, 11 of 12 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @web-padawan)
src/vaadin-rich-text-editor.html, line 108 at r2 (raw file):
value: { type: Object, readOnly: true,
Should be writable.
test/basic.html, line 151 at r2 (raw file):
}); it('should be read only and disallow modifications', () => {
Should be updated once value
becomes writable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 12 files reviewed, 2 unresolved discussions (waiting on @YuriyVaadin)
src/vaadin-rich-text-editor.html, line 108 at r2 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
Should be writable.
Done.
test/basic.html, line 151 at r2 (raw file):
Previously, YuriyVaadin (Yuriy Yevstihnyeyev) wrote…
Should be updated once
value
becomes writable.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 5 of 12 files at r2, 6 of 6 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
This is now 100%? I can start using Quill in my LitElement components and still be in Shadow-DOM? |
@aadamsx We released version 1.0.0-alpha2 yesterday. Here's an example of it being used with lit element https://glitch.com/edit/#!/ritzy-bill |
Fixes #2
For now there are 2 main problems and both are related to the
select
controls:However, at least the normal button controls are confirmed to work. So let's start with something like that and consider a proper fix for select controls to be added later.
Note: PR includes a built
Quill
version with a patched polyfill. This should be suitable for MVP but we have to revisit it before 1.0.0 stable release.This change is