Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Issue #346 Updating Vagrant dev version #347

Merged
merged 1 commit into from
May 6, 2019

Conversation

hferentschik
Copy link
Contributor

@hferentschik hferentschik commented May 4, 2019

  • disabling failing Cucumber test
  • updating maintainers list

fix for issue #346

- disabling failing Cucumber test
- updating maintainers list
@hferentschik hferentschik requested a review from davividal May 6, 2019 07:43
@hferentschik
Copy link
Contributor Author

@davividal wdyt?

@davividal
Copy link
Collaborator

Looks nice for me.
I'm currently having issues with bento/debian boxes when running on Mac. I'm still trying to understand the issue so I can write a test for it and solve. So, I see no problems in disabling some failing tests since I'm bound to look into that in the (very) near future.

@hferentschik
Copy link
Contributor Author

Looks nice for me.

Cool.

I'm currently having issues with bento/debian boxes when running on Mac.

Anything which is reported? Which version of bento/debian? I am on macOS as well.

I'm still trying to understand the issue so I can write a test for it and solve.

Sounds good. Regarding the disabled test. It used to work, but it seems something has changed. See also #342.

The Cucumber tests are a great way to run through the most common use cases. Be aware, that if a Cucumber run fails you might have to manually check and kill a locally running Landrush process. I am looking into how to improve this. Probably by a beforeEach hook.

So, I see no problems in disabling some failing tests since I'm bound to look into that in the (very) near future.

+1

@hferentschik hferentschik merged commit fad42aa into vagrant-landrush:master May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants