Fix use of VALAC so that it is respected everywhere #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ricotz said about this "note the vala version retrieval and library usage". I had a look at |
rrthomas
force-pushed
the
allow-different-valac
branch
2 times, most recently
from
fffc988
to
4ac5645
Compare
rrthomas
changed the title
rrthomas
force-pushed
the
allow-different-valac
branch
2 times, most recently
from
826c6c3
to
87a24cf
Compare
@ricotz, ping? If I recall correctly, you weren't happy with the second commit, but the first seemed uncontroversial? If that's so, I can remove the second commit from this PR. |
rrthomas
force-pushed
the
allow-different-valac
branch
2 times, most recently
from
fe42698
to
c5b7b39
Compare
rrthomas
force-pushed
the
allow-different-valac
branch
from
c5b7b39
to
2e350c6
Compare
rrthomas
force-pushed
the
allow-different-valac
branch
from
2e350c6
to
0d18caa
Compare
This fixes some places where the VALAC setting was not respected
Document the need to use --disable-unversioned
ricotz
force-pushed
the
allow-different-valac
branch
from
d6b02f0
to
64bcb9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes in two parts:
Makefile,generatorandvaladoc-example-testerto useVALACeverywhere.VALACto be set in the environment. This makes it easy to use a differentvalacto test. Document inREADME.mdthat it must use a different API version from other installed versions.