elementary OS 7 App Template #26
Conversation
|
Perhaps we should rename the old template to |
|
Oh yeah, that makes sense. This would be similar to what happens with the Should I make this change myself? |
Yeah, go ahead |
|
The elementary OS templates have been renamed now |
|
I've noticed an issue with libadwaita styling not being overridden with elementary styling when building and running the flatpak through GNOME Builder. Here's what the app looks like when running it from GNOME Builder: However, this is what the app looks like when running it using VS Code's Flatpak extension (Note: I am using the non-flatpak version of VS Code): This is the expected behaviour. The flatpak also has elementary styling after installing it using the I'm not sure what's causing this issue. I suspect that it has something to do with GNOME Builder. |
|
@colinkiama I just wrapped up a bunch of merge requests. You'll have to rebase ( |
elementary styling and decorations should now consistently show
eos -> eos6 eos7 -> eos
colinkiama
force-pushed
the
eos7-template
branch
from
7e8cf98
to
808c48c
Compare
|
I decided to drop libadwaita from the template. The issue with GNOME Builder is now fixed. This is ready to be merged now. |
|
I don't remember why we included libadwaita in the template. Was it ever a part of the elementary SDK? |
|
elementary has been relying on libhandy a lot for gestures and some of the widgets it comes with. I assumed that it would be just as easy to include libadwaita as it's supposed to be the successor for libhandy for GTK 4 apps. It turns out, it's not as easy as it seems. Libadwaita is not in the elementary-sdk package but it is available in the elementary flatpak platform package. |
|
Hi, just following up on this PR |
|
oh lol I just made a PR for the same thing, guess i should've read the existing PRs |
An elementary OS 7 app template that follows best practices from elementary.