common automatic update #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Jun 29, 2024
mbaldessari
commented
- Properly quote vault kv command
- ACM chart version 0.0.2
- golang-external-secrets chart version 0.0.4
- hashicorp-vault chart version 0.0.2
- Implement multi-source
- Add tests for proper multisource support on spokes
- Update tests after upgrading common
- Fix linting issues in python test code
When using a password with a dollar, the oc exec commands run inside the
vault are not properly escaped, casing the dollar signed to be
interpreted by the shell inside the vault pod.
So a password like 'Y$yxn54&qXAxpUd2*yGH' will become 'Y&qXAxpUd2*yGH'
in the vault.
This is because the command that is being run ends up being:
oc exec -n vault vault-0 -i -- sh -c "vault kv patch -mount=secret global/mysecret dollar=Y$yxn54&qXAxpUd2*yGH"
The `$yxn54` will be interpreted by the shell inside vault.
Let's fix this by running a properly escaped command:
oc exec -n vault vault-0 -i -- sh -c "vault kv patch -mount=secret global/mysecret dollar='"'Y$yxn54&qXAxpUd2*yGH'"'"
Reported-By: Chris Butler <[email protected]>
Properly quote vault kv command
Update chart versions
Multisource on spokes
bkumar73
pushed a commit
to bkumar73/multicloud-gitops
that referenced
this pull request
Jul 15, 2024
Upgrade vault-helm to v0.26.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.