Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-2022 -> windows-2025, Do not persist credentials #3988

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kichura
Copy link

@Kichura Kichura commented Nov 29, 2024

Updates the CI's OS image from Windows Server 2022 -> Windows Server 2025 basically, Don't merge this yet as image has no runners available atm but soon, there will be. ™️

Also credentials will not be persisted through checkouts which is to prevent exposing workflow to greater risks than imagined.

@pyrates999
Copy link

This software is not for the server versions of windows.

@Kichura
Copy link
Author

Kichura commented Nov 30, 2024

This software is not for the server versions of windows.

i am aware of this. this is meant for compiling the software through github actions and that explorerpatcher mainly focuses on windows 11 itself nowadays in terms of base.

@Kichura Kichura changed the title Update windows-2022 -> windows-2025 Update windows-2022 -> windows-2025, Do not persist credentials Dec 15, 2024
Prevents workflow from getting exposed to greater risks than imagined, This was caught by the "zizmor" rust library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants