Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup wallet is not added to master Safe #331

Closed
oaksprout opened this issue Sep 7, 2024 · 4 comments · Fixed by #351
Closed

Backup wallet is not added to master Safe #331

oaksprout opened this issue Sep 7, 2024 · 4 comments · Fixed by #351

Comments

@oaksprout
Copy link
Collaborator

User adds a backup wallet, but it isn't persisted.

pearl_logs_2024-09-06T11-55-08.075Z-0.1.0-rc125.zip

Severity: critical. 2 users reported, fundamentally affects security.

@truemiller
Copy link
Collaborator

truemiller commented Sep 9, 2024

Likely frontend related -- address is undefined, though a string in the debug logs

The setup process hasn't changed however, but will take a look

Need context around whether they added their wallet on creation, or not

@oaksprout
Copy link
Collaborator Author

@truemiller we don't know if they added the wallet on creation, they can't remember.

Note that I previously had an issue where a non-checksummed address was not possible to add – not sure if that's related. Would show up in the cli.log if so.

@oaksprout
Copy link
Collaborator Author

Logs from another affected user
pearl_logs_2024-09-08.zip

@truemiller
Copy link
Collaborator

truemiller commented Sep 13, 2024

Checksumming fix in #351 should solve this, but can reopen if this experienced again.

@truemiller truemiller linked a pull request Oct 4, 2024 that will close this issue
3 tasks
@truemiller truemiller removed a link to a pull request Oct 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants