Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure backup address is checksummed before submitting to backend #351

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Sep 13, 2024

@oaksprout mentioned he experienced errors when backup wallet address was not checksummed

fix ensures the address is checksummed in the background

  • allows for non-checksummed input (as to not frustrate users)
  • will send the checksummed address to middleware when creating a safe (to add as signer)

tried using validation rules on the Antd input, but transform and validator functions don't update input value. hence the validation on submit.

should resolve #331, Trello ticket

Video

(made a small fix mid way through, works as expected now)

checksumming.video.mp4

Copy link
Collaborator

@mohandast52 mohandast52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 , Going forward, it might be helpful to include some screenshots/videos or visualizations to ensure we don’t miss any UX details and to avoid potential regressions.

@truemiller truemiller merged commit 567dd7d into staging Sep 13, 2024
4 checks passed
@truemiller truemiller deleted the fix/checksum-invalidity branch September 13, 2024 15:06
@truemiller truemiller linked an issue Sep 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup wallet is not added to master Safe Non-checksummed backup address leads to account creation failure
4 participants